Skip to content
Snippets Groups Projects

KTLS: additional ciphersuites

Merged František Krenželok requested to merge ktls_ciphersuites into master
All threads resolved!

Add support for additional ciphersuites #1434 (closed) Support added for the following as they are supported by GnuTLS the rest might be added in future

  • TLS_AES_128_CCM_SHA256
  • TLS_CHACHA20_POLY1305_SHA256

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated / NEWS entry present (for non-trivial changes)
  • CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTION.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by František Krenželok

Merge request reports

Pipeline #711985833 passed

Pipeline passed for 24bd0559 on ktls_ciphersuites

Approved by

Merged by František KrenželokFrantišek Krenželok 2 years ago (Dec 3, 2022 6:10pm UTC)

Merge details

Pipeline #712474546 passed

Pipeline passed for 443b4b07 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Looks good to me, thanks!

  • Daiki Ueno approved this merge request

    approved this merge request

  • František Krenželok marked the checklist item Commits have Signed-off-by: with name/author being identical to the commit author as completed

    marked the checklist item Commits have Signed-off-by: with name/author being identical to the commit author as completed

  • František Krenželok marked the checklist item Test suite updated with functionality tests as completed

    marked the checklist item Test suite updated with functionality tests as completed

  • František Krenželok marked the checklist item Code modified for feature as completed

    marked the checklist item Code modified for feature as completed

  • František Krenželok marked the checklist item CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout) as completed

    marked the checklist item CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout) as completed

  • František Krenželok resolved all threads

    resolved all threads

  • mentioned in commit 443b4b07

  • mentioned in issue #1434 (closed)

  • mentioned in issue #1384 (closed)

  • Please register or sign in to reply
    Loading