Skip to content
Snippets Groups Projects

Disable some tests in fips mode

Merged Zoltán Fridrich requested to merge ZoltanFridrich/gnutls:zfridric_devel3 into master
All threads resolved!

There are some parts of the testsuite that use algorithms that are not approved by FIPS. This patch disables these parts if FIPS mode is enabled.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated / NEWS entry present (for non-trivial changes)
  • CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTION.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Zoltán Fridrich

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Zoltán Fridrich marked the checklist item Commits have Signed-off-by: with name/author being identical to the commit author as completed

    marked the checklist item Commits have Signed-off-by: with name/author being identical to the commit author as completed

  • Zoltán Fridrich marked the checklist item Code modified for feature as completed

    marked the checklist item Code modified for feature as completed

  • Zoltán Fridrich marked the checklist item Test suite updated with functionality tests as completed

    marked the checklist item Test suite updated with functionality tests as completed

  • Zoltán Fridrich marked the checklist item Test suite updated with negative tests as completed

    marked the checklist item Test suite updated with negative tests as completed

  • Zoltán Fridrich marked the checklist item Documentation updated / NEWS entry present (for non-trivial changes) as completed

    marked the checklist item Documentation updated / NEWS entry present (for non-trivial changes) as completed

  • Zoltán Fridrich marked the checklist item CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout) as completed

    marked the checklist item CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout) as completed

  • Daiki Ueno
  • added 1 commit

    • 2c337617 - Disable some tests in fips mode

    Compare with previous version

  • Zoltán Fridrich changed title from Disable some tests in fips mode to [WIP] Disable some tests in fips mode

    changed title from Disable some tests in fips mode to [WIP] Disable some tests in fips mode

  • Daiki Ueno marked the checklist item No obvious mistakes in the code as completed

    marked the checklist item No obvious mistakes in the code as completed

  • Daiki Ueno approved this merge request

    approved this merge request

  • Zoltán Fridrich resolved all threads

    resolved all threads

  • Zoltán Fridrich changed title from [WIP] Disable some tests in fips mode to Disable some tests in fips mode

    changed title from [WIP] Disable some tests in fips mode to Disable some tests in fips mode

  • Daiki Ueno mentioned in commit 47706b2d

    mentioned in commit 47706b2d

  • merged

  • changed milestone to %Release of GnuTLS 3.7.4

  • Please register or sign in to reply
    Loading