.gitlab-ci.yml: replace valgrind checks with ASan
Running the full test suite under valgrind wastes a lot of time and may cause intermittent failures due to timeout. We have them mainly for VALGRIND_MAKE_MEM_UNDEFINED client request, though the ASan tests now cover the equivalent after f23c3a6c.
Checklist
-
Commits have Signed-off-by:
with name/author being identical to the commit author -
Code modified for feature -
Test suite updated with functionality tests -
Test suite updated with negative tests -
Documentation updated / NEWS entry present (for non-trivial changes) -
CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)
Reviewer's checklist:
-
Any issues marked for closing are addressed -
There is a test suite reasonably covering new functionality or modifications -
Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTION.md
-
This feature/change has adequate documentation added -
No obvious mistakes in the code
Merge request reports
Activity
@asosedkin any opinions?
- Resolved by Daiki Ueno
re f23c3a6c: good to have it!
re this MR: not particularly convinced on the time saving side.
Quoting select competing stage 3 job durations from the latest pipeline of master at the time of writing:
passed debian-cross/aarch64-linux-gnu/test 00:53:03 passed debian-cross/arm-linux-gnueabihf/test 00:50:56 failed fedora-notools/test 03:00:02 passed fedora-static-analyzers/test 01:40:34 passed fedora-valgrind-aggressive/test 00:29:23 passed fedora-valgrind/test 00:28:36
Doesn't look like valgrind jobs are on the critical path. If timeouts are caused by hanging tests and not raw performance considerations, I'd prefer test fixing and both checkks coexisting.
@dueno This merge request is marked as work in progress with no update for very long time. We are now closing it, but please re-open if you are still interested in finishing this merge request.
added 315 commits
-
90f8149f...2a134d43 - 314 commits from branch
gnutls:master
- 6a348c09 - .gitlab-ci.yml: replace valgrind checks with ASan
-
90f8149f...2a134d43 - 314 commits from branch
mentioned in commit c63824ca