Skip to content
Snippets Groups Projects

Implement new tls channel biding types

Merged Ruslan Marchenko requested to merge rufferson/gnutls:tlsv1.3-cb into master

Current support for tls channel binding extraction api (gnutls_session_channel_binding()) is very rudimentary (tls-unique only) and partial (does not work for TLSv1.3). This MR targets to add missing binding types to cover existing protocols (TLSv1.2 and TLSv1.3).

Closes #1041 (closed) Closes #1214 (closed)

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated / NEWS entry present (for non-trivial changes)
  • CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTION.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Daiki Ueno

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Daiki Ueno
  • Daiki Ueno
  • Daiki Ueno
  • Ruslan Marchenko added 3 commits

    added 3 commits

    • 8ff4eaf1 - Restructure gnutls_session_channel_binding and add tls-exporter
    • 9ebee00c - Add tls-server-end-point tls channel binding implementation.
    • c028876c - Add tests for call gnutls_session_channel_binding

    Compare with previous version

  • Ruslan Marchenko resolved all threads

    resolved all threads

  • Daiki Ueno approved this merge request

    approved this merge request

  • Daiki Ueno enabled an automatic merge when the pipeline for c028876c succeeds

    enabled an automatic merge when the pipeline for c028876c succeeds

  • Daiki Ueno marked the checklist item Any issues marked for closing are addressed as completed

    marked the checklist item Any issues marked for closing are addressed as completed

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading