Skip to content
Snippets Groups Projects

pk: Use 'mpz_init_set' instead of 'memcpy'.

Closed civodul requested to merge civodul/gnutls:mpz-init-set into master

This changes code to use mpz_init_set instead of memcpy where appropriate, as suggested by @dueno in https://lists.gnutls.org/pipermail/gnutls-help/2020-December/004677.html.

Note that it's primarily a stylistic improvement; it does not solve the issues that were discussed in the thread above.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated / NEWS entry present (for non-trivial changes)
  • CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTION.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Well, although I suggested that, I guess it would require further changes, e.g., releasing the copy with mpz_clear (with proper zeroization if needed). Hopefully I can reproduce the original issue this weekend :-)

  • Author Guest

    Yeah, CI suggests I messed up with something.

  • @civodul This merge request is marked as work in progress with no update for very long time. We are now closing it, but please re-open if you are still interested in finishing this merge request.

  • closed

Please register or sign in to reply
Loading