Skip to content

Verify that cert_list_size > 0 and cert_list != NULL

Tom Carroll requested to merge incentive.design/gnutls:check_cert_list_argument into master

cert_list_size (similarly, ca_list_size) are signed integers that specify the length of cert_list (ca_list). As the size variable is used for compute a memory allocation, there is an implicit assumption that it is greater than zero. This patch makes the assumption explicit by checking that cert_list_size > 0. Additionally, cert_list cannot be NULL as cert_list_size > 0.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated / NEWS entry present (for non-trivial changes)
  • CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTION.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Daiki Ueno

Merge request reports