Skip to content
Snippets Groups Projects

Make y parameter optional in gnutls_privkey_import_dsa_raw().

Merged Hans Leidekker requested to merge hansleidekker/gnutls:dsa_import_optional_y into master

Like 81b0a397. Windows key blobs may not include y.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated / NEWS entry present (for non-trivial changes)
  • CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTION.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Daiki Ueno

Merge request reports

Pipeline #211082375 passed

Pipeline passed for 270c3050 on hansleidekker:dsa_import_optional_y

Merged by Daiki UenoDaiki Ueno 4 years ago (Nov 5, 2020 2:37pm UTC)

Loading

Pipeline #212238059 passed

Pipeline passed for 58427cec on master

Test coverage 76.30% from 0 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hans Leidekker marked the checklist item CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout) as completed

    marked the checklist item CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout) as completed

  • Daiki Ueno marked the checklist item Any issues marked for closing are addressed as completed

    marked the checklist item Any issues marked for closing are addressed as completed

  • Daiki Ueno marked the checklist item No obvious mistakes in the code as completed

    marked the checklist item No obvious mistakes in the code as completed

  • Daiki Ueno marked the checklist item This feature/change has adequate documentation added as completed

    marked the checklist item This feature/change has adequate documentation added as completed

  • Daiki Ueno marked the checklist item There is a test suite reasonably covering new functionality or modifications as completed

    marked the checklist item There is a test suite reasonably covering new functionality or modifications as completed

  • Thank you! Looks good to me.

  • Daiki Ueno approved this merge request

    approved this merge request

  • Daiki Ueno mentioned in commit 58427cec

    mentioned in commit 58427cec

  • merged

Please register or sign in to reply
Loading