Skip to content
Snippets Groups Projects

cipher: expose raw ChaCha20 cipher

Merged Daiki Ueno requested to merge tmp-chacha into master

See the discussion on the nettle list.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated / NEWS entry present (for non-trivial changes)
  • CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTION.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Dmitry Baryshkov

Merge request reports

Pipeline #127690710 passed

Pipeline passed for a682bdd2 on tmp-chacha

Test coverage 76.80% (0.10%) from 1 job

Merged by Daiki UenoDaiki Ueno 4 years ago (Mar 19, 2020 12:49pm UTC)

Loading

Pipeline #127775282 passed

Pipeline passed for f523ca00 on master

Test coverage 76.80% (0.10%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • LGTM otherwise.

  • Daiki Ueno added 17 commits

    added 17 commits

    • 3cacfe68...ea2a81e5 - 13 commits from branch master
    • 3462a7fc - cipher: expose raw ChaCha20 cipher
    • 9f02612a - nettle: vendor in ChaCha20 implementation from nettle
    • 6f5e98f0 - cipher: allow setting ChaCha20 initial block counter
    • 852470a2 - abi: add enum values for GNUTLS_CIPHER_CHACHA20_*

    Compare with previous version

  • Daiki Ueno resolved all threads

    resolved all threads

  • Dmitry Baryshkov
  • Daiki Ueno added 3 commits

    added 3 commits

    • 252a4dd5 - nettle: vendor in ChaCha20 implementation from nettle
    • 15ec7e3c - cipher: allow setting ChaCha20 initial block counter
    • a682bdd2 - abi: add enum values for GNUTLS_CIPHER_CHACHA20_*

    Compare with previous version

  • Daiki Ueno resolved all threads

    resolved all threads

  • Dmitry Baryshkov marked the checklist item Any issues marked for closing are addressed as completed

    marked the checklist item Any issues marked for closing are addressed as completed

  • Dmitry Baryshkov marked the checklist item There is a test suite reasonably covering new functionality or modifications as completed

    marked the checklist item There is a test suite reasonably covering new functionality or modifications as completed

  • Dmitry Baryshkov marked the checklist item Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTION.md as completed

    marked the checklist item Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTION.md as completed

  • Dmitry Baryshkov marked the checklist item No obvious mistakes in the code as completed

    marked the checklist item No obvious mistakes in the code as completed

  • Dmitry Baryshkov marked the checklist item This feature/change has adequate documentation added as completed

    marked the checklist item This feature/change has adequate documentation added as completed

  • Dmitry Baryshkov approved this merge request

    approved this merge request

  • merged

  • Daiki Ueno mentioned in commit f523ca00

    mentioned in commit f523ca00

  • Author Owner

    Thanks for the review!

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading