Hotkey window should appear only upon KeyUp, not KeyDown
Bug report
- iTerm2 version: 3.5.0beta9
- OS version: macOS Monterey 12.3.1
Detailed steps to reproduce the problem
- Create a new Hotkey Window profile and assign a double-tap ⇧Shift to open it.
- In another app, type ⇧ ⇧A (or any ⇧ + capital letter).
What happened
The Hotkey window pops up. This frequently results in accidentally typing into the Hotkey window.
For example, if I wanted to type hi Frank
in a textbox somewhere, and I hesitated and pressed an extra ⇧ before Frank
:
hi ⇧⇧Frank
The Hotkey window pops up immediately before typing the F, and you end up typing Frank
into the terminal instead of the textbox.
This also comes up when playing a game that requires you to use ⇧ and ⇧F in quick succession.
What should have happened
The Hotkey window should appear only upon the KeyUp event of the second ⇧, not the KeyDown, as long as that second tap is released before hotKeyDoubleTapMaxDelay
seconds.
Edited by Daniel Li