Skip to content

fix some bug in EMAIL_BACKEND vs EMAIL_URL settings

martin milon requested to merge martinmilon/glitchtip-backend:master into master

allows to set all EMAIL_... settings individually, today's solution prevents from setting custom EMAIL_BACKEND as EMAIL_URL parsing will override it.

Turns out, EMAIL_URL requires valid schema, raises an error if it doesn't get it (so we can't set ignore-me schema), and infers the backend to use from it, so it does override EMAIL_BACKEND that is set just before. passing EMAIL_BACKEND in the backend kwargs of env.email_url is not an option either as this would make it override the inferred one, so that would just switch the problem on the other side.

This bug makes it impossible, to the best of my knowledge, to actually use sendgrid or mailgun, as we can't set the BACKEND_URL to their respective backends.

The documentation here : https://glitchtip.com/documentation/install#configuration should also be updated to reflect this change, i don't know where it is to change it tho

Merge request reports