12.7 Create:Source Code retrospective
This is an asynchronous retrospective for the 12.7 release, following the process described in the handbook.
This issue is private (confidential) to the Create:Source Code team, plus anyone else who worked with the team during 12.7, to ensure everyone feels comfortable sharing freely. On 2020-02-26, in preparation for the engineering-wide 12.7 Retrospective, the issue will be opened up to the public, as long as everyone is comfortable with this. You're free to redact any comments that contain information that you'd like to stay private before that date.
Please look at back at your experiences working on this release, ask yourself
For each point you want to raise, please create a new discussion with the relevant emoji, so that others can weigh in with their perspectives, and so that we can easily discuss any follow-up action items in-line.
If there is anything you are not comfortable sharing here, please message your manager directly. Note, however, that 'Emotions are not only allowed in retrospectives, they should be encouraged', so we'd love to hear from you here if possible.
Issues we shipped
- Follow-up from "Check mergeability of MR asynchronously"
- Restyle changes header and file tree
- PullRequestImporter should not use deprecated assignee_id column
- Remove ignoring of
merge_requests_require_code_owner_approvalcolumn on projects - Design for zen code review
- adding a MR comment on a part of the file not in diff corrupts comments and triggers a 500 error
- Merge request discussions API doesn't reject an error input in some case
- word-diff or word-level highlighting for suggestion diff
- More issues - this list only includes deliverables!
Issues that slipped
- 500 errror when diff huge commit
- Move MergeabilityCheckService processing to Sidekiq
- Add minimal merge-ref based diff option to merge request comparisons
- Scope merge request approval rules to protected branches
- Total deliverables closed: 8
- Total issues closed: 37
- Total MRs merged: 44