Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • webapp webapp
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 712
    • Issues 712
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 26
    • Merge requests 26
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gittergitter
  • webappwebapp
  • Merge requests
  • !2366

Follow-up fixes to bridging admin power levels MR !2343

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Eric Eastwood requested to merge 2343-follow-up into develop Jan 31, 2023
  • Overview 0
  • Commits 3
  • Pipelines 2
  • Changes 2

Follow-up fixes to bridging admin power levels MR !2343 (merged)

  1. When someone joins the room, if we add them as an admin of the Matrix room, also add them as an admin of the historical Matrix room
  2. Make sure to call cleanupAdminsInMatrixRoomIdAccordingToGitterRoomId(...) alongside addAdminsInMatrixRoomIdAccordingToGitterRoomId(...) when we ensureCorrectRoomState(...)
  3. Refactor to use ensureStateEvent(...) instead of ensureStateEventAsMxid(...) as the bridge user
Edited Jan 31, 2023 by Eric Eastwood
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 2343-follow-up