Skip to content

Fix flaw in room resumption code skipping room it should have resumed from

Eric Eastwood requested to merge 2609-fix-flawed-room-resumption into develop

Fix flaw in room resumption code skipping room it should have resumed from

See #2609 (comment 1239203705)

Fixing bug in our room resumption code where our resume position checkpoint file tracks the oldest room ID we are currently processing. But then we're using it as $gt: resumeFromGitterRoomId which goes to the room after the room we are supposed to resume from. We should be using $gte: resumeFromGitterRoomId. This doesn't seem like it would account for so much difference as we didn't restart the script that many times.

We now better disambiguate "resume" from "lastThingProcessed" type language to better distinguish when to use $gt vs $gte.

Follow-up to !2313 (merged)

Edited by Eric Eastwood

Merge request reports