Skip to content

Fix collaborators view by listening on room id change

Tomas Vik (OOO back on 2024-08-12) requested to merge 2503-collaborators-view-fix into develop

Closes #2503 (closed)

The issue was that the permissions field stopped changing reliably after we included permissions to room during serialization https://gitlab.com/gitlab-org/gitter/webapp/-/issues/2503#note_337401329

The permissions field contains { admin: true } so when switching between rooms where I'm an admin, the collaboratorsView didn't register the change.

troupeContext.troupe.permissions
Object { admin: true }

I'm not going to be trying to write an automated test for this scenario.

Testing strategy

  1. Go to a room where you are the only user (and admin)
  2. Switch to a room where you are not the only user
  3. See the collaborators view disappear
Edited by Tomas Vik (OOO back on 2024-08-12)

Merge request reports