Skip to content

Add thread support to Sidecar (embedded renderer)

Eric Eastwood requested to merge 77-sidecar-thread-support into develop

Add thread support to Sidecar (embedded renderer).

The TMF width isn't optimized at all but is fine for a first iteration. In the future, we could make it full width like mobile. People can always use the popout functionality to use the full experience.

There is also a slight color border because I added some padding to the top to make the thread exit button easy to access.

Fix https://gitlab.com/gitlab-org/gitter/sidecar/-/issues/77

Testing strategy

  1. Run the Sidecar microsite, npm run start-microsite -> http://localhost:3001/microsite/dist/
  2. Press the "Open chat" button to get the DOM populated
  3. Replace the Gitter iframe with <iframe frameborder="0" src="http://localhost:5000/MadLittleMods/postcss-css-variables/~embed"></iframe> (replace the URI with your own room that has threads)
  4. Open the thread
  5. Also test when not signed in

Edited by 🤖 GitLab Bot 🤖

Merge request reports