Skip to content

Add GL_PROJECT support to the permissions view

Eric Eastwood requested to merge 2411-GL_PROJECT-permissions-view into develop

Add GL_PROJECT support to the permissions view

Part of https://gitlab.com/gitlab-org/gitter/webapp/issues/2411

Other MR where we added GL_GROUP support to the permissions view: https://gitlab.com/gitlab-org/gitter/webapp/-/merge_requests/1763

Testing strategy

  1. Insert a new GitLab Gitter group into Mongo
    db.groups.insert({
            "name" : "gitlab-org-gitter-webapp",
            "uri" : "gitlab-org-gitter-webapp",
            "lcUri" : "gitlab-org-gitter-webapp",
            "lcHomeUri" : "gitlab-org-gitter-webapp/home",
            "homeUri" : "gitlab-org-gitter-webapp/home",
            "sd" : {
                    "externalId" : "3601513",
                    "linkPath" : "gitlab-org/gitter/webapp",
                    "public" : true,
                    "admins" : "GL_PROJECT_MAINTAINER",
                    "members" : "PUBLIC",
                    "type" : "GL_PROJECT"
            },
    });
  2. Insert a room in that new GitLab group
    db.troupes.insert({
            "groupId" : db.groups.findOne({ "lcUri" : "gitlab-org-gitter-webapp", })._id,
            "lcUri" : "gitlab-org-gitter-webapp/community",
            "uri" : "gitlab-org-gitter-webappy/community",
            "sd" : {
                    "internalId" : db.groups.findOne({ "lcUri" : "gitlab-org-gitter-webapp", })._id,
                    "extraAdmins" : [ ],
                    "extraMembers" : [ ],
                    "members" : "PUBLIC",
                    "public" : true,
                    "admins" : "GROUP_ADMIN",
                    "type" : "GROUP"
            }
    });
  3. Visit gitlab-org-gitter-webapp/community signed in with your GitLab account (ensure the user you sign in with is a maintainer of https://gitlab.com/gitlab-org/gitter/webapp)
  4. Room settings dropdown -> Permissions -> Edit community permissions (in the bottom-left corner of the modal)
  5. Notice it says Anyone with maintainer access to the gitlab-org/gitter/webapp project on GitLab
Edited by Eric Eastwood

Merge request reports