Skip to content

Add finger swiping to left-menu

Eric Eastwood requested to merge 2386-finger-swipe-left-menu into develop

Add finger swiping to left-menu so it follows as you swipe across the screen.

Previously the left-menu would not react and follow your finger as you swipe. It would only detect a swipe gesture and open/close the left-menu

Fix https://gitlab.com/gitlab-org/gitter/webapp/issues/2386

Testing strategy

  1. Open up a room on mobile (can use devtools mobile emulation)
  2. Swipe back and forth to expand/collapse the left-menu
  3. Also test that the manual controls still work

I've tested on an iPhone 8, iPhone 6 and an old Moto E(2nd gen) ✔

It feels slightly chonky on the iPhone 6. Feels fine on the iPhone 8 and Moto E(2nd gen) which I feel is a pretty low end device but not sure exactly about spec comparison to the iPhone 6.

Edited by Eric Eastwood

Merge request reports