Skip to content

Don't redirect to communities when accessing private rooms

Tomas Vik requested to merge 2366-404-for-private-rooms into develop

Closes #2366 (closed)

This MR removes the redirect that was causing #2366 (closed).

This was a weird edge case. When a private room doesn't have a / in its URI, we'll redirect to the community that the room belongs to.

My motivation for removing this logic (apart from it causing infinite redirect in the /ivew case) is that we shouldn't share any information about private rooms (not even whether they exist and what community they belong to).

Local testing

  1. Change room URI in DB to be the same as the room's community (e.g. test-community/community -> test-community) and make the room private. (I'm not even sure whether there are any other cases in production, I didn't go to DB and do the intersection of community and room URIs)
  2. Go to the community URI and observe 404 (as opposed to 302 to the identical URI without this change)

Effect on production

In the /iview example the /iview route stops redirecting to community home which might not be desirable. We can ask if they want to rename the private room and change the homeUri back to /iview.

Merge request reports