Add hide room functionality to room settings dropdown
Add hide room functionality to room settings dropdown.
We are adding this so it is available somewhere when the new Vue left menu is in place. But this feature will be available outside of the feature flag as well.
Shows a browser notification for an error
Based off of
- https://gitlab.com/gitlab-org/gitter/webapp/blob/3c5f9870c74cc0ddf02ad75a578ca2747e7381ba/public/js/views/menu/room/primary-collection/primary-collection-item-view.js#L170-185
- https://gitlab.com/gitlab-org/gitter/webapp/-/blob/3c5f9870c74cc0ddf02ad75a578ca2747e7381ba/public/js/views/menu/room/base-collection/base-collection-view.js#L149-154
Testing strategy
Try the following with a normal room and a one to one room,
- Visit a room and hide it from the room settings dropdown
- Switch to another room and refresh
- The room should remain hidden
To test that we don't have an appEvents
infinite loop (this should only be a problem with vue-left-menu
on anyway),
- Send a message
- Check your CPU to make sure it's not spinning at 100%
Closes #2168 (closed)
Edited by Eric Eastwood