Skip to content

Remove dead security descriptor updater code

Eric Eastwood requested to merge remove-dead-sd-updater into develop

Remove dead security descriptor updater code

This method was introduced in https://gitlab.com/gitlab-org/gitter/webapp/commit/2d3b775037d19bf12d1b403376e4fe412181171c#1f22745dcec1a68e40ae2cf8884185fbe232427a_71_79 but I didn't see any usage ever in the history 😕. Perhaps it was used in a quick and dirty migration script.

Discovered while investigating https://gitter.zendesk.com/agent/tickets/9353 where the user renamed a -> b and had a a-group. There is now a supposedly new a account that has the same GitHub ID as the a-group created with the old a account.

I ran through this same situation and didn't see this happen, https://gitlab.com/gitlab-org/gitter/webapp/issues/1670#note_113326913

I was looking for any code that updated/upserted a groups security descriptor after the fact.

The only other place this seems possibly is when we use upsertGroup in the createGroup method which will just give a 409 conflict when you try to create a group with the same URI.

Edited by Eric Eastwood

Merge request reports