Skip to content

Fix unreadItems endpoint returning a 404 because of accidental rename

Eric Eastwood requested to merge fix-unread-items-after-room-service-module-refactor into develop

Fix unreadItems endpoint returning a 404 because of accidental rename during refactor in https://gitlab.com/gitlab-org/gitter/webapp/merge_requests/1165#note_76365005

We caught this on staging 👍 19.3.0, https://gitlab.com/gitlab-org/gitter/webapp/merge_requests/1170

I looked at all non-module results for -.*'\./ in https://gitlab.com/gitlab-org/gitter/webapp/merge_requests/1165.diff to ensure there aren't other accidental refactors of this same kind.

This fell through the cracks because we had no tests around the /v1/user/:userId/rooms/:roomId/unreadItems endpoint. Added tests here 🚀

We still need to get the integration tests running in CI. Currently they get skipped because the test integration secrets are never pulled in, https://gitlab.com/gitlab-org/gitter/webapp/issues/1918

Edited by Eric Eastwood

Merge request reports