Skip to content

Fix "Allow private repo access" profile menu item not redirecting to GitHub OAuth upgrade flow

Eric Eastwood requested to merge fix-allow-private-repo-scope into develop

Fix "Allow private repo access" profile menu item not redirecting to GitHub OAuth upgrade flow

Fix https://gitlab.com/gitlab-org/gitter/webapp/issues/1872

The upgrade-access-routes in router-app(top frame) were not kicking in because the <a href="#upgraderepoaccess" target="_top"> hash doesn't bubble up to the top frame and make the route apply.

Switching to a direct link also helps us avoid the pop-up blocker that happens with window.open

Edited by 🤖 GitLab Bot 🤖

Merge request reports