Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
webapp
webapp
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 684
    • Issues 684
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 26
    • Merge requests 26
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gitter
  • webappwebapp
  • Merge requests
  • !1077

Merged
Created Jul 31, 2017 by Eric Eastwood@MadLittleModsOwner9 of 9 tasks completed9/9 tasks

GitLab Issue Decorations

  • Overview 3
  • Commits 1
  • Pipelines 18
  • Changes 46

GitLab Issue Decorations


Message snippet example:

Public GitHub: https://github.com/gitterHQ/sidecar/issues/71 gitterHQ/sidecar#71
Non-existent GitHub: https://github.com/gitterHQ/sidecar/issues/999999 gitterHQ/sidecar#999999
PR GitHub: https://github.com/gitterHQ/sidecar/pull/39 gitterHQ/sidecar#39

Public GitLab: https://gitlab.com/gitlab-org/gitter/webapp/issues/1947 gitter/webapp#1947
Non-existent GitLab: https://gitlab.com/gitlab-org/gitter/webapp/issues/999999 gitlab-org/gitter/webapp#999999
MR GitLab: https://gitlab.com/gitlab-org/gitter/webapp/merge_requests/1077 gitlab-org/gitter/webapp!1077

GitLab short references not supported and assumed to be GitHub atm

Before After


Todo

  • Update gitter-markdown-processor, see branch feature/gitlab-decorations
    • See https://gitlab.com/gitlab-org/gitter/gitter-markdown-processor/merge_requests/11 and https://gitlab.com/gitlab-org/gitter/gitter-markdown-processor/merge_requests/14
    • Update dep in webapp
  • Add support for access tokens (vs private tokens) in node-gitlab
    • See https://github.com/repo-utils/gitlab/pull/39
      • Wait for merge and new npm release (currently relying on branch)
    • Now using https://www.npmjs.com/package/gitlab instead
  • Add gitlab__public_token_pool=xxx,xxx,xxx to production, staging, etc secrets
    • https://gitlab.com/gl-gitter/secrets/tree/master/webapp
    • Use a new account that doesn't have access to any projects
    • Deploy secrets to prod servers
    • https://gitlab.com/gl-gitter/secrets/merge_requests/10
  • The GitLab issue API doesn't allow anonymous requests
    • We currently are using .json URLs, https://gitlab.com/gitlab-org/gitter/webapp/issues/1755.json but they don't include the author
    • We are going to use a token pool for anonymous or non-GitLab users
  • Should we fix up commit decorations before merge?
    • Currently decorates and is linked for the open button but doesn't show any contents in the popover
    • nah, iteration
  • Add api scope to GitLab applications (endpoint to get issue/MR info is in the GitLab API)
  • Add GitLab integration test secrets to CI/CD variables

Closes https://gitlab.com/gitlab-org/gitter/webapp/issues/1762, https://gitlab.com/gitlab-org/gitter/webapp/issues/1755

Edited Oct 13, 2020 by 🤖 GitLab Bot 🤖
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: feature/gitlab-decorations