GitLab

GitLab Issue Decorations

---

Message snippet example:

Public GitHub: https://github.com/gitterHQ/sidecar/issues/71 gitterHQ/sidecar#71
Non-existent GitHub: https://github.com/gitterHQ/sidecar/issues/999999 gitterHQ/sidecar#999999
PR GitHub: https://github.com/gitterHQ/sidecar/pull/39 gitterHQ/sidecar#39

Public GitLab: https://gitlab.com/gitlab-org/gitter/webapp/issues/1947 gitter/webapp#1947
Non-existent GitLab: https://gitlab.com/gitlab-org/gitter/webapp/issues/999999 gitlab-org/gitter/webapp#999999
MR GitLab: https://gitlab.com/gitlab-org/gitter/webapp/merge_requests/1077 gitlab-org/gitter/webapp!1077

GitLab short references not supported and assumed to be GitHub atm

Before	After

---

Todo

• Update gitter-markdown-processor, see branch feature/gitlab-decorations
  • See https://gitlab.com/gitlab-org/gitter/gitter-markdown-processor/merge_requests/11 and https://gitlab.com/gitlab-org/gitter/gitter-markdown-processor/merge_requests/14
  • Update dep in webapp
• Add support for access tokens (vs private tokens) in node-gitlab
  • See https://github.com/repo-utils/gitlab/pull/39
    • Wait for merge and new npm release (currently relying on branch)
  • Now using https://www.npmjs.com/package/gitlab instead
• Add gitlab__public_token_pool=xxx,xxx,xxx to production, staging, etc secrets
  • https://gitlab.com/gl-gitter/secrets/tree/master/webapp
  • Use a new account that doesn't have access to any projects
  • Deploy secrets to prod servers
  • https://gitlab.com/gl-gitter/secrets/merge_requests/10
• The GitLab issue API doesn't allow anonymous requests
  • We currently are using .json URLs, https://gitlab.com/gitlab-org/gitter/webapp/issues/1755.json but they don't include the author
  • We are going to use a token pool for anonymous or non-GitLab users
• Should we fix up commit decorations before merge?
  • Currently decorates and is linked for the open button but doesn't show any contents in the popover
  • nah, iteration
• Add api scope to GitLab applications (endpoint to get issue/MR info is in the GitLab API)
• Add GitLab integration test secrets to CI/CD variables

---

Closes https://gitlab.com/gitlab-org/gitter/webapp/issues/1762, https://gitlab.com/gitlab-org/gitter/webapp/issues/1755