Use the single group service account GET endpoint

Jimmy Spagnolarequested to merge
gitlab-community/gitlab-org/terraform-provider-gitlab:use-single-service-account-get into main

What does this MR do?

The group service account resource and data source paged through the list endpoint to find a single account by ID, because no single-GET endpoint was available in the client. client-go v3 now exposes Groups.GetServiceAccount, which returns email just like the list endpoint, so both reads now call it directly.

  • internal/provider/resource_gitlab_group_service_account.go — Read uses Groups.GetServiceAccount
  • internal/provider/datasource_gitlab_group_service_account.go — same
  • Dropped the findGroupServiceAccount list-scan helper
  • Dropped the (err == nil && serviceAccount == nil) sentinel checks — a missing account is now a real 404, so api.Is404(err) covers it

waitForServiceAccountDeletion still polls Users.GetUser; that's a different check (user record vs. service account record) and is left unchanged.

Related issues

Closes #6881 (closed)

Note: #6881 (closed) is labeled workflow::blocked pending the endpoint reaching GA — please confirm that's resolved before merging.

🤖 Generated with Claude Code

Merge request reports