Skip to content

Fix ES settings from String to Int

Patrick Rice requested to merge fix-es-settings into main

Closes #6205 (Confidential)

Merge Request: Fix ES settings from String to Int

Description

This merge request fixes the type of elasticsearch_namespace_ids and elasticsearch_project_ids from string to int in the gitlab_application_settings resource.

Diff

The following diff explains the changes made in this merge request:

The TestAccGitlabApplicationSettings_elasticSearchSettings test has been added to test the new functionality. This test is skipped by default because GitLab validates the elasticsearch URL so it won't pass without a running instance, but can be run by running a local Elasticsearch Docker image.

The elasticsearch_namespace_ids and elasticsearch_project_ids fields in the gitlab_application_settings resource have been changed from string to int. This change was made to match the type of these fields in the GitLab API.

Testing

The following tests have been added to verify the changes:

  • TestAccGitlabApplicationSettings_elasticSearchSettings

Edited by Patrick Rice

Merge request reports