datasource/gitlab_project: don't fail if user has no access to push rules
This avoids errors like this: https://gitlab.com/gitlab-org/frontend/renovate-gitlab-bot/-/jobs/3784211549#L45
Merge request reports
Activity
assigned to @timofurrer
/cc @leipert
changed milestone to %15.9
added bugfunctional groupconfigure [DEPRECATED] labels
added typebug label
added devopsconfigure [DEPRECATED] sectionops labels
requested review from @PatrickRice
2 Errors 22e2f6a3: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. 22e2f6a3: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer No reviewer available No maintainer available If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Patrick Rice
@timofurrer - This change makes sense to me, but feels like it should have some better documentation (and how do we test it? Probably need to create a new access token somewhere?). It's difficult for an end user to know when the
push_rules
array is legitimately empty vs empty due to lack of permissions here. We'll obviously know if someone puts in a ticket because of the debug message, but I wonder if there is a better way to provide feedback to the end users.Edited by Patrick Rice
added 1 commit
- cc00e6d7 - datasource/gitlab_project: don't fail if user has no access to push rules
added 1 commit
- a7fa0560 - datasource/gitlab_project: don't fail if user has no access to push rules
added 1 commit
- 938f8f17 - datasource/gitlab_project: don't fail if user has no access to push rules
added workflowin review label
@PatrickRice
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
added 17 commits
-
938f8f17...8a070ede - 16 commits from branch
main
- 22e2f6a3 - datasource/gitlab_project: don't fail if user has no access to push rules
-
938f8f17...8a070ede - 16 commits from branch
enabled an automatic merge when the pipeline for 42e76b95 succeeds
mentioned in commit c4296c44