Resolve "gitlab_project_share_group resource not properly refreshed"
Closes #1353 (closed)
Merge request reports
Activity
assigned to @PatrickRice
Hey @PatrickRice!
👋 Thank you for your contribution to GitLab. Please refer to the contribution flow documentation for a quick overview of the process, and the merge request (MR) guidelines for the detailed process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.To enable automated checks on your MR, please configure Danger for your fork.
You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer No reviewer available Timo Furrer (
@timofurrer
) (UTC+1)If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 Dangeradded bugfunctional label
added 1 commit
- 7dcd096b - Fix issue where project share group isn't removed on read
requested review from @timofurrer
@timofurrer - This should all be set. More code in the test than in the fix
😄 - Resolved by Patrick Rice
- Resolved by Patrick Rice
- Resolved by Timo Furrer
- Resolved by Timo Furrer
@PatrickRice looks good overall - I've left some minor suggestions. Back to you
🏓 added workflowin review label and removed workflowin dev label
changed milestone to %15.8
added 1 commit
- c134d102 - Move test to PreConfig, add logging and early break from the loop