Skip to content

Enhancing existing rule rule-XMLStreamRdr.yml

Bhavya Kaushal requested to merge java-xxe-xmlstreamrdr into main

What does this MR do?

  1. Updates rule rule-XMLStreamRdr.yml to add patterns from community rule
  2. Updates test file with new tests.
  3. Updates mapping.
  4. Updates license and moves rule to lgpl-cc folder per licensing

What are the relevant issue numbers?

Addresses issue : gitlab-org/gitlab#441042

Does this MR meet the acceptance criteria?

  • The test cases cover both positive and negative cases and are also annotated with appropriate semgrep annotations:
    • For positive cases: // ruleid: ...
    • For negative cases: // ok: ....
  • Following metadata fields exist for the rule(s) added/updated in this MR:
    • owasp with both 2017 and 2021 mappings.
    • category: "security"
    • cwe
    • shortDescription
    • security-severity
  • The message field is valid and contains a secure code example.
  • Applicable license is mentioned in the rule if embedded/taken from external source.
  • Relevant labels including workflow labels are appropriately selected.

Merge request reports