Skip to content

Enhance sast-rules lgpl\javascript\traversal\rule-express-lfr.yml

Lanka De Alwis requested to merge feat/issue-440775-rule-express-lfr into main

What does this MR do?

  • Update the .yml rule pattern
  • Update the rule message
  • Update the test file with new test cases

What are the relevant issue numbers?

gitlab-org/gitlab#440775 (closed)

Does this MR meet the acceptance criteria?

  • The test cases cover both positive and negative cases and are also annotated with appropriate semgrep annotations:
    • For positive cases: // ruleid: ...
    • For negative cases: // ok: ....
  • Following metadata fields exist for the rule(s) added/updated in this MR:
    • owasp with both 2017 and 2021 mappings.
    • category: "security"
    • cwe
    • shortDescription
    • security-severity
  • The message field is valid and contains a secure code example.
  • Applicable license is mentioned in the rule if embedded/taken from external source.
  • Relevant labels including workflow labels are appropriately selected.

Merge request reports