Skip to content

Enhanced the JavaScript eval reuire rule

Jayanaka Fonseka requested to merge feat/issue-440562/JavaScript-Eval-Require into main

What does this MR do?

Modified the JavaScript Eval Require rule by converting it to the taint mode and updated the test cases.

What are the relevant issue numbers?

gitlab-org/gitlab#440562 (closed)

Does this MR meet the acceptance criteria?

  • The test cases cover both positive and negative cases and are also annotated with appropriate semgrep annotations:
    • For positive cases: // ruleid: ...
    • For negative cases: // ok: ....
  • Following metadata fields exist for the rule(s) added/updated in this MR:
    • owasp with both 2017 and 2021 mappings.
    • category: "security"
    • cwe
    • shortDescription
    • security-severity
  • The message field is valid and contains a secure code example.
  • Applicable license is mentioned in the rule if embedded/taken from external source.
  • Relevant labels including workflow labels are appropriately selected.

Merge request reports