Updating rule Go Unsafe TLS Version
What does this MR do?
- Updates patterns of Go sast rule - unsafe TLS Version - https://gitlab.com/gitlab-org/security-products/sast-rules/-/blob/main/go/crypto/rule-tlsversion.yml?ref_type=heads
- Adds more test cases for both true positives and false positives.
What are the relevant issue numbers?
Addresses issue: gitlab-org/gitlab#452634 (closed)
Does this MR meet the acceptance criteria?
-
The test cases cover both positive and negative cases and are also annotated with appropriate semgrep annotations: - For positive cases:
// ruleid: ...
- For negative cases:
// ok: ....
- For positive cases:
-
Following metadata fields exist for the rule(s) added/updated in this MR: -
owasp
with both 2017 and 2021 mappings. category: "security"
cwe
shortDescription
security-severity
-
-
The message field is valid and contains a secure code example. -
Applicable license is mentioned in the rule if embedded/taken from external source. -
Relevant labels including workflow labels are appropriately selected.
Edited by Bhavya Kaushal