Add Reviewer Roulette to sast-rules
What does this MR do?
This MR adds a reviewer roulette to sast-rules
in order to, as described in , streamline the contribution process.
The workflow we've strived for, after a lot of debugging, is for there to be both a reviewer and maintainers.
This is in line with the way reviews are performed on https://gitlab.com/gitlab-org/gitlab. Often, the reviewer shepherds an MR until the end, being so intimate with it that another set of eyes is a good idea even if it's just for the purpose of rubber stamping it.
The important additions in order to enable danger-bot
, danger-review
and simple-roulette
are as follow:
project.yml
here
Simple roulette itself is implemented here https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles/-/blob/master/lib/danger/rules/simple_roulette/Dangerfile#L50
We are using the GitLab component for danger-review
https://gitlab.com/gitlab-org/components/danger-review
For questions, you might ask in the #g_engineering_productivity
channel. Should that fail, @rymai
, @godfat-gitlab
or @leipert
have experience with the projects involved.
What are the relevant issue numbers?
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated for GitLab EE, if necessary -
Documentation created/updated for this project, if necessary -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Job definition updated, if necessary -
Conforms to the code review guidelines -
Conforms to the Go guidelines -
Security reports checked/validated by reviewer