Skip to content

Close Gap for char rule

Julian Thome requested to merge char into main

Tackling char rule. Pushing coverage from 73/81 to 81/81. The table below shows the "before" state.

+----------------------------------------------------------------------------------------------------------------+
|                                            # char (coverage 73/81)                                             |
+--------------------------------------------------------------+------------+---------+--------------------------+
| finding                                                      | flawfinder | semgrep | rule                     |
+--------------------------------------------------------------+------------+---------+--------------------------+
| c-flawfinder-test/buffer#test-MultiByteToWideChar.c$char$9-  | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-MultiByteToWideChar.c$char$8-  | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-char_TCHAR.c$char$11-          | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-char_TCHAR.c$char$12-          | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-fscanf_sscanf.c$char$27-       | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-fscanf_sscanf.c$char$29-       | X          | -       | -                        |
| c-flawfinder-test/buffer#test-fscanf_sscanf.c$char$26-       | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-fscanf_sscanf.c$char$25-       | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-getchar_fgetc.c$char$11-       | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-gets__getts.c$char$5-          | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-lstrcat_wcscat.c$char$9-       | X          | -       | -                        |
| c-flawfinder-test/buffer#test-lstrcat_wcscat.c$char$8-       | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-lstrcpy_wcscpy.c$char$9-       | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-lstrcpy_wcscpy.c$char$8-       | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-lstrcpyn_wcsncpy.c$char$9-     | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-lstrcpyn_wcsncpy.c$char$8-     | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-memcpy_CopyMemory.c$char$14-   | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-memcpy_CopyMemory.c$char$13-   | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-memcpy_CopyMemory.c$char$15-   | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-scanf_vscanf.c$char$5-         | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-sprintf_vsprintf.c$char$5-     | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-strcat.c$char$7-               | X          | -       | -                        |
| c-flawfinder-test/buffer#test-strcpy.c$char$9-               | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-strcpy.c$char$8-               | X          | -       | -                        |
| c-flawfinder-test/buffer#test-streadd_strecpy.c$char$11-     | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-streadd_strecpy.c$char$10-     | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-streadd_strecpy.c$char$5-      | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-strncat.c$char$9-              | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-strncat.c$char$8-              | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-strncpy.c$char$9-              | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-strncpy.c$char$8-              | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-strtrns.c$char$11-             | X          | -       | -                        |
| c-flawfinder-test/format#test-fprintf_vprintf.c$char$9-      | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/format#test-snprintf_vsnprintf.c$char$5-   | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/input#test-recv_recvfrom.c$char$24-        | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/input#test-recv_recvfrom.c$char$14-        | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/input#test-recv_recvfrom.c$char$15-        | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/integer#test-atoi_atol.c$char$10-          | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/misc#test-cuserid.c$char$8-                | X          | -       | -                        |
| c-flawfinder-test/race#test-chmod.c$char$15-                 | X          | -       | -                        |
| c-flawfinder-test/race#test-readlink.c$char$7-               | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/shell#test-system.c$char$9-                | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/tmpfile#test-tmpnam_tempnam.c$char$7-      | X          | -       | -                        |
| c-flawfinder-test/buffer#test-MultiByteToWideChar.c$char$9-9 | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-MultiByteToWideChar.c$char$8-8 | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-char_TCHAR.c$char$12-12        | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-char_TCHAR.c$char$11-11        | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-char_TCHAR.c$char$10-10        | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-char_TCHAR.c$char$9-9          | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-fscanf_sscanf.c$char$27-27     | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-fscanf_sscanf.c$char$26-26     | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-fscanf_sscanf.c$char$25-25     | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-getchar_fgetc.c$char$11-11     | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-gets__getts.c$char$5-5         | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-lstrcat_wcscat.c$char$8-8      | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-lstrcat_wcscat.c$char$7-7      | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-lstrcpy_wcscpy.c$char$9-9      | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-lstrcpy_wcscpy.c$char$8-8      | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-lstrcpyn_wcsncpy.c$char$9-9    | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-lstrcpyn_wcsncpy.c$char$8-8    | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-memcpy_CopyMemory.c$char$15-15 | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-memcpy_CopyMemory.c$char$14-14 | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-memcpy_CopyMemory.c$char$13-13 | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-scanf_vscanf.c$char$5-5        | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-sprintf_vsprintf.c$char$5-5    | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-strcpy.c$char$9-9              | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-streadd_strecpy.c$char$11-11   | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-streadd_strecpy.c$char$10-10   | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-streadd_strecpy.c$char$5-5     | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-strncat.c$char$9-9             | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-strncat.c$char$8-8             | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-strncpy.c$char$9-9             | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/buffer#test-strncpy.c$char$8-8             | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/format#test-fprintf_vprintf.c$char$9-9     | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/format#test-snprintf_vsnprintf.c$char$5-5  | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/input#test-recv_recvfrom.c$char$24-24      | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/input#test-recv_recvfrom.c$char$15-15      | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/input#test-recv_recvfrom.c$char$14-14      | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/integer#test-atoi_atol.c$char$10-10        | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/race#test-readlink.c$char$7-7              | X          | X       | c/buffer/rule-char_TCHAR |
| c-flawfinder-test/shell#test-system.c$char$9-9               | X          | X       | c/buffer/rule-char_TCHAR |
+--------------------------------------------------------------+------------+---------+--------------------------+
Edited by Julian Thome

Merge request reports