Skip to content

Log browserker scan output

Cameron Swords requested to merge log-config-errors into main

What does this MR do?

Log the output once the Browserker scanning process is complete. This ensures that error messages are not hidden when the scanner fails.

Example

For a successful scan with warnings:

2023-07-14 15:29:32,506 Browserker completed with exit code 0
2023-07-14 15:29:32,506 Browserker: 2023-07-14T15:29:29.390 WRN MAIN  deprecated: selector has no type, future versions will require css:, id:, name:, or xpath: prefix selector="a[href='/pancake/2']"

For a scan with invalid configuration:

2023-07-14 15:33:00,709 Browserker completed with exit code 1
2023-07-14 15:33:00,709 Browserker: 2023-07-14T15:33:00.709 ERR MAIN  configuration validation failed error="failed to parse TOML configuration due to (20, 27): parsing error: unescaped control character U+000A"
2023-07-14 15:33:00,709 Browserker: 2023-07-14T15:33:00.709 FTL MAIN  failed to initialize browserker: failed to create configuration: configuration validation failed

What are the relevant issue numbers?

gitlab-org/gitlab#418246 (closed)

Edited by Cameron Swords

Merge request reports