Skip to content

Shellcheck doesn't fail when a script isn’t valid

Cameron Swords requested to merge shellcheck-errors-silently into master

What does this MR do?

shellcheck was added recently to verify DAST shell scripts uphold a certain standard. Unfortunately, the job doesn't fail (i.e. script exits with non zero code) if a bash script is not valid.

This MR fixes the above issue by using the -0 xargs option. From their documentation:

-0: Change xargs to expect NUL (``\0'') characters as separators, instead of spaces and newlines.  This is expected to be used in concert with the -print0 function in find(1).

Obtaining the TEST_DIR environment variable has been simplified by using realpath.

Edited by Cameron Swords

Merge request reports