Skip to content

Fix UID mapping issues when running browser based

What does this MR do?

fixes some assumptions about the uid being the same across the docker container lifecycle for browser-based scans and fixes related issue with volume mounts and badger with virtualbox.

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab/-/issues/331204

Testing

  1. export some environment variables:
export DAST_BROWSER_DATA_PATH=/browserker/browserker_data
export ZAP_UID=1000 
export BROWSERKER_UID=1001
  1. build the dast image:
invoke dast.build --set-zap-and-browserker-uid
  1. build the dast-future image:
invoke dast.build-future --set-zap-and-browserker-uid
  1. validate previously failing test succeeds (volume mount issue):
bash_unit ./test/end-to-end/test-browserker-login-path.sh
  1. validate previously failing test succeeds (uid mapping issue):
bash_unit ./test/end-to-end/test-future-full-scan.sh
  1. test expectations can be refreshed.
invoke test.regenerate-e2e-expected-json --skip-build
Edited by Philip Cunningham

Merge request reports