Skip to content

Use disable_scanners for excluded rules

Avielle Wolfe requested to merge use-disable-scanners-for-exclude-rules into master

What does this MR do?

Previously, we excluded passive rules and active rules in different ways:

Passive rules: excluded using ZAP server configuration arguments when starting the server. These were set by ExcludedRulesConfigurationBuilder
Active rules: excluded using policy files that were written before the ZAP server was started. To support this functionality we had created the models in src/models/active_scan and ActiveScanPolicy

Now active and passive scan rules will be excluded…

                         IN THE SAME WAY

This MR replaces the old exclusion functionality with the usage of zapv2.pscan.disable_scanners and zapv2.ascan.disable_scanners, both of which are called in ScanScriptWrapper right after the ZAP server is started

It also removes the code used for the old functionality

What are the relevant issue numbers?

gitlab-org/gitlab#250651 (closed)

Edited by Avielle Wolfe

Merge request reports