Skip to content

Remove request postData and response content

Cameron Swords requested to merge remove-large-memory-message-values into master

What does this MR do?

Removes the response.content and request.postData values from Alert. This ensures the data can be garbage collected as these values can have large amounts of data.

request.postData will contain the HTTP body of a requested that was POSTed to a URL. There is no theoretical limit to this size.

response.content will contain the HTTP body of a response from any GET/POST/PUT/HEAD/etc call to a URL. There is no theoretical limit to this size, and we know this will be large when files can be downloaded.

What are the relevant issue numbers?

gitlab-org/gitlab#225270 (closed)

Does this MR meet the acceptance criteria?

Edited by Avielle Wolfe

Merge request reports

Loading