Skip to content
Snippets Groups Projects

Update DAST release scripts

Merged Cameron Swords requested to merge duplicate-dast-docker-release into master
All threads resolved!

What does this MR do?

The Secure Report Format schema heavily borrows from the DAST release scripts. As another round of reviews occurred on these scripts, the code quality was greatly improved. This MR merges these changes back into the DAST repository.

There is also a requirement for DAST Docker images to be released to the analayzers/dast Docker registry. This will make it easier for offline GitLab setups to download all of GitLab Secure images. The ability to deploy to more than one registry is also included in this MR.

Does this MR meet the acceptance criteria?

Edited by Cameron Swords

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Craig Smith

      @cam_swords I like this refactor a lot! I just have a couple of questions and want to confirm my understanding of the release process.

      My understanding, from this change, is:

      1. check this version of dast hasn't already been released
      2. create multiple tags of the dast image and push to the registry (is that https://gitlab.com/gitlab-org/security-products/dast/container_registry)
      3. create multiple tags of the dast image and push to the registry (these tags start with an alternative name)
      4. Create a tag in the git repo for the release commit
      5. Creates a release for the release page https://gitlab.com/gitlab-org/security-products/dast/-/releases

      Is that correct?

  • Craig Smith assigned to @cam_swords and unassigned @craigmsmith

    assigned to @cam_swords and unassigned @craigmsmith

  • Cameron Swords added 2 commits

    added 2 commits

    • 371d4faa - Use a function to remove duplicated checks
    • 1cf19384 - Rename tag image to tag and push image

    Compare with previous version

  • assigned to @craigmsmith and unassigned @cam_swords

  • Craig Smith approved this merge request

    approved this merge request

  • assigned to @philipcunningham and unassigned @craigmsmith

  • This MR, partially addresses gitlab-org/gitlab#215930 (closed)

    Edited by Seth Berger
  • Philip Cunningham
  • Philip Cunningham
  • Philip Cunningham approved this merge request

    approved this merge request

  • assigned to @cam_swords and unassigned @philipcunningham

  • Cameron Swords added 5 commits

    added 5 commits

    Compare with previous version

  • assigned to @philipcunningham and unassigned @cam_swords

  • Philip Cunningham approved this merge request

    approved this merge request

  • Philip Cunningham resolved all threads

    resolved all threads

  • mentioned in commit bdd28354

  • Please register or sign in to reply
    Loading