Update DAST release scripts
What does this MR do?
The Secure Report Format schema heavily borrows from the DAST release scripts. As another round of reviews occurred on these scripts, the code quality was greatly improved. This MR merges these changes back into the DAST repository.
There is also a requirement for DAST Docker images to be released to the analayzers/dast Docker registry. This will make it easier for offline GitLab setups to download all of GitLab Secure images. The ability to deploy to more than one registry is also included in this MR.
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated for GitLab EE, if necessary -
Documentation created/updated for this project, if necessary -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Job definition updated, if necessary -
Job definition example -
Vendored CI Templates (also in CE)
-
-
Conforms to the code review guidelines -
Conforms to the Go guidelines -
Security reports checked/validated by reviewer
Merge request reports
Activity
changed milestone to %13.0
removed Category:Backup/Restore of GitLab instances label
- Resolved by Philip Cunningham
@craigmsmith could you please review this?
assigned to @craigmsmith and unassigned @cam_swords
- Resolved by Craig Smith
- Resolved by Craig Smith
- Resolved by Philip Cunningham
- Resolved by Craig Smith
@cam_swords I like this refactor a lot! I just have a couple of questions and want to confirm my understanding of the release process.
My understanding, from this change, is:
- check this version of dast hasn't already been released
- create multiple tags of the dast image and push to the registry (is that
https://gitlab.com/gitlab-org/security-products/dast/container_registry
) - create multiple tags of the dast image and push to the registry (these tags start with an alternative name)
- Create a tag in the git repo for the release commit
- Creates a release for the release page
https://gitlab.com/gitlab-org/security-products/dast/-/releases
Is that correct?
assigned to @cam_swords and unassigned @craigmsmith
assigned to @craigmsmith and unassigned @cam_swords
assigned to @philipcunningham and unassigned @craigmsmith
- Resolved by Philip Cunningham
@cam_swords Once this is merged, is the next step to set the CI Variables?
- $ALTERNATE_CI_REGISTRY_USERNAME
- $ALTERNATE_CI_REGISTRY_PASSWORD
- $ALTERNATE_CI_REGISTRY_IMAGE
Edited by Seth Berger
This MR, partially addresses gitlab-org/gitlab#215930 (closed)
Edited by Seth Berger- Resolved by Philip Cunningham
- Resolved by Philip Cunningham
assigned to @cam_swords and unassigned @philipcunningham
added 5 commits
-
1cf19384...8f884c6a - 4 commits from branch
master
- 926a84d7 - Merge branch 'master' into duplicate-dast-docker-release
-
1cf19384...8f884c6a - 4 commits from branch
assigned to @philipcunningham and unassigned @cam_swords
mentioned in commit bdd28354
@cam_swords merged!