Skip to content

Pin zap add-ons to specific versions

Cameron Swords requested to merge pin-zap-add-ons into master

What does this MR do?

ZAP add-ons come pre-installed with each ZAP Docker image (see /zap/plugin on a running DAST image). When a ZAP scan is executed, ZAP will attempt to update all of the installed add-ons.

This causes problems:

  • A DAST user can't decide not to take the add-on (the auto-update functionality is hard-coded)
  • DAST can't be run in an offline mode
  • The DAST engineering team tests suddenly fail when a release is made to dependent packages in https://github.com/zaproxy/zap-extensions/releases

This MR disables add-on auto-updating when the command line option --auto-update-addons false is passed to /analyze. Add-ons will update if the option is not provided. A later decision can be made as to whether or not add-on updates should be disabled by default.

This MR in part solves issues gitlab-org/gitlab#198456 (closed) and gitlab-org/gitlab#12728 (closed). It also fixes the broken master build on DAST.

Does this MR meet the acceptance criteria?

Edited by Cameron Swords

Merge request reports