fix: Use `Array.include?` for CHANGELOG inclusion (!11) · Merge requests · GitLab.org / security-products / danger bot

Lucas Charles requested to merge test-changelog-only-modified into master Jan 25, 2021

There was a bug previously in file inclusion that would blow up based on the Filelist appending of git.added_files and git_modified_files. The behavior seemed inconsistent based on several edgecase (only added files, only excluded files, and a mixture). I also have a suspicion something changed upstream in either the danger project or gitlab-build-images but wasn't able to track it down.

Regardless, this seems to work to address the previous issue ci-templates!197 (merged)

This was really hard to test and I couldn't get danger adequately tested outside of pipelines so I've been triggering pipelines using DANGER_BOT_VERSION overrides, see the many attempts: https://gitlab.com/gitlab-org/security-products/analyzers/ruleset/-/pipelines?page=1&scope=all&ref=theoretick-master-patch-17941

See successful pipeline, note the SHA fetched matches the one from this branch: https://gitlab.com/gitlab-org/security-products/analyzers/ruleset/-/jobs/985762459

Edited Jan 25, 2021 by Lucas Charles

fix: Use `Array.include?` for CHANGELOG inclusion

Merge request reports