Skip to content

Make DS, SAST QA compatible with non-DinD mode

Fabien Catteau requested to merge 212147-share-qa-no-dind into master

Make .qa and .update-qa job templates compatible with the non-DinD mode by introducing $GOT and $WANT variables. Also, update job policies of predefines jobs to skip them when DinD is disabled. These jobs are qa-dependency_scanning, update-qa-dependency_scanning, qa-sast, and update-qa-sast.

See gitlab-org/gitlab#212147 (closed)

Testing

Integration test for Dependency Scanning w/o DinD, no_dind-FREEZE branch: gitlab-org/security-products/tests/ruby-bundler!77 (merged)

Regression test for Dependency Scanning w/ DinD, master branch: https://gitlab.com/gitlab-org/security-products/tests/ruby-bundler/pipelines/128749111

No integration test for SAST b/c non-DinD mode is not yet tested, see gitlab-org/gitlab#38086 (closed)

Regression test for SAST w/ DinD, master branch: https://gitlab.com/gitlab-org/security-products/tests/go/pipelines/128765794

"update QA" jobs show up in the pipelines as expected but they have not been tested.

Edited by 🤖 GitLab Bot 🤖

Merge request reports