Skip to content

Remove allow_failure: true from goimports job

Adam Cohen requested to merge remove-allow-failure-true-from-goimports into master

What does this MR do?

The goimports job was added 2 years ago by Add a formatting check for Go projects (!259 - merged) and at the time, we decided to set allow_failure: true to prevent failing master pipelines for projects that aren't formatted properly. After 2 years, I believe all projects should now be running goimports as expected, so we should remove the allow_failure: true so that we can enforce proper formatting. This will prevent issue like this from occurring.

What are the relevant issue numbers?

N/A

Does this MR meet the acceptance criteria?

Merge request reports