Skip to content

Draft: chore: replace goimports job with golangci-lint

Lucas Charles requested to merge master-patch-fe28 into master

What does this MR do?

We have started to see some drift between goimports and go lint jobs, probably due to goimports pinning to latest. We can actually lint goimports easily through golangci-lint so this MR updates the lint configuration to check imports directly and we can drop the extra job.

I'm not sure exactly where this changed in goimports but the recent bump to golang 1.19 is likely the cause. Here are the two analyzers/results@main goimports jobs between 1.17 and 1.19:L

Testing with gitlab-org/security-products/analyzers/report!55 (closed), but so far it doesn't work

What are the relevant issue numbers?

N/A

Does this MR meet the acceptance criteria?

Edited by Lucas Charles

Merge request reports