Skip to content

Drop scan.primary_identifiers in compare_report.sh

Lucas Charles requested to merge theoretick-master-patch-78618 into master

What does this MR do?

Drops scan.primary_identifiers to improve report comparability.

Moving forward we should use the integration test approach for validating primary_identifiers but it's a large maintenance burden to support those using downstreams so it seems more prudent to remove from the comparison for the time being.

Relates to gitlab-org/security-products/analyzers/semgrep!146 (diffs), feel free to check the diff (around Version 30) to see the full list of identifiers in expectations which is rather unmanageable (if your browser manages to load it).

What are the relevant issue numbers?

gitlab-org/gitlab#368284 (closed)

Does this MR meet the acceptance criteria?

Edited by Lucas Charles

Merge request reports