Skip to content

Support WANT variable in DS QA job

Fabien Catteau requested to merge fix-ds-qa-support-WANT-variable into master

What does this MR do?

Support WANT variable in DS QA job. See experiment: gitlab-org/security-products/tests/ruby-bundler!1267 (closed)

This fixes failing jobs like https://gitlab.com/gitlab-org/security-products/tests/ruby-bundler/-/jobs/1431818906

The DS QA script only needs to support DS_REPORT_URL. The DS QA job uses qa/expect/$WANT as a default value for DS_REPORT_URL, and DEPENDENCY_SCANNING_REPORT as a default value for WANT. This covers all cases, though DS_REPORT_URL isn't always a URL.

This change can easily be ported to SAST and Secret Detection, removing the need to port gitlab-org/security-products/analyzers/integration-test!4 (merged).

Follow-up MR: revert gitlab-org/security-products/analyzers/integration-test!4 (merged) since the DS QA script no longer needs to support DEPENDENCY_SCANNING_VARIABLE. See gitlab-org/security-products/analyzers/integration-test!7 (merged)

What are the relevant issue numbers?

This fixes the bug introduced when merging !236 (merged), and related to gitlab-org/gitlab#299038 (closed).

Does this MR meet the acceptance criteria?

Edited by Fabien Catteau

Merge request reports