Omit invalid end lines from the generated report
What does this MR do?
Certain combinations of method annotations can cause Spotbugs to produce a finding whose end line comes before its start line.
In addition to being semantically invalid, these findings can cause downstream problems during report optimisation. The optimisation logic requires the end line to come after the start line, and will halt otherwise. This means that users' CI jobs can fail if report optimisation is enabled (as it is by default), and their project happens to contain the right combination of annotations to trigger this bug with Spotbugs.
An upstream issue has been filed (https://github.com/spotbugs/spotbugs/issues/2279).
What are the relevant issue numbers?
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated for GitLab EE, if necessary -
Documentation created/updated for this project, if necessary -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Job definition updated, if necessary -
Auto-DevOps template (also in CE) -
Job definition example -
CI Templates (to be removed) -
Vendored CI Templates (also in CE)
-
-
Conforms to the code review guidelines -
Conforms to the Go guidelines -
Security reports checked/validated by reviewer
Edited by Lucas Charles