Skip to content

Fix custom CA cert support

Daniel Paul Searles requested to merge custom-ca-certs-fix into master

What does this MR do?

Fix support for custom CA certificates

The main problem was that the proper java certificate store was never found due to the JAVA_HOME env var not being properly set before importing custom ca certs. This fixes things by adding certificates to all stores found in the asdf java installs (currently java 8 and java 11).

The reasoning for searching for the cert stores is that java 8 and java 11 both have different paths. Java 8 puts it within a jre dir that doesn't exist for the java 11 install.

Add better tests for custom CA certificates

https://gitlab.com/gitlab-org/security-products/tests/java-maven/-/pipelines/431355913 shows the new test failing for the latest spotbugs image and the latest pipeline run for this MR shows that it now passes!

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

Edited by Lucas Charles

Merge request reports