Skip to content

Improve the usability of BAP in MRs

Craig Smith requested to merge craigmsmith-bap-should-not-be-allowed-to-fail into main

What does this MR do?

Remove allow_failure: true from the BAP jobs

BAP is the SAST team's last line of defense to avoid releasing unintended rule changes. allow_failure: true is easy to ignore which could result in an MR with BAP failure being merged into production. Removing allow_failure: true will reduce this change.

Add instructions for BAP failure

BAP is expected to fail in certain situations, this MR adds documentation on what to do when that happens, both in the README and in the BAP CI job console output.

What are the relevant issue numbers?

Document handling expected BAP failures (gitlab-org/gitlab#464645 - closed) • Craig Smith, Tal Kopel • 17.1

Does this MR meet the acceptance criteria?

Edited by Craig Smith

Merge request reports