Skip to content

Move test passthrough URL to semgrep-gitlab

Vishwa Bhat requested to merge vbhat161-fix-qa-ruleset into main

What does this MR do?

In the recent puzzling situation of semgrep's failing integration-test CI jobs, the root cause (or the only possible explanation) turns out to be due to the changes in the external semgrep ruleset in one of the test projects -- go/custom-ruleset-synthesis. More explanation is discussed here.

This MR changes the following:

  • Changes the passthrough URL to gitlab-based semgrep registry instead of gosec-based in the test project - go/custom-ruleset-synthesis
  • Adds a regenerated expectation artifact for go/custom-ruleset-synthesis test project based on the changed ruleset source mentioned above.
  • Includes the missing vulnerability_finding_signatures value into GITLAB_FEATURES feature-flag for using go - when using ruleset synthesis test spec to mimic the consistency across other language tests.

Does this MR meet the acceptance criteria?

Edited by Lucas Charles

Merge request reports